Resolve Babel options ahead of time 🎉 #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should disable the Babel cache, given that we're now really good at managing it ourselves. Need to set |
|
Generally looks good. Will give it a more thorough read later today. I've ran it on a bunch of projects of mine and the performance seems to be the same as master, which is good. |
|
Sorry about the delay. I did a thorough review now and nothing more to point out. Excellent work as always Mark. |
|
No worries! I better write docs and release hullabaloo at 1.0 now though 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 001 requires us to resolve Babel options in the main process. This PR lands that new behavior, fixing #707 in the process.
Note that with these changes AVA will no longer resolve
.babelrcfiles relative to the test file. Instead it only looks at a.babelrcfile in the project directory.AVA's
stage-4andtransform-test-filespresets no longer have the package hashes of their plugins included in the caching hash for Babel transforms. This behavior will shift topackage-hashitself, see novemberborn/package-hash#22.The caching hash is now derived from the full Node.js version, rather than just the major. This allows for presets / plugins which vary behavior based on feature differences in minor releases. I'm assuming that people don't update their Node.js versions all of the time, so this shouldn't really have an impact. Note that cached files for other versions are preserved, so this doesn't impact users who switch between Node.js versions.
We're now better at detecting whether Babel options have changed, especially for users who
extendother files. We're also hashing the presets and plugins and will reapply transforms when these versions change.